lkml.org 
[lkml]   [2022]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] staging: rtl8712: check for alloc fail in _r8712_init_recv_priv()
On Tue, Oct 25, 2022 at 09:57:38AM +0300, Dan Carpenter wrote:
> On Mon, Oct 24, 2022 at 11:24:07PM +0200, Nam Cao wrote:
> > The function _r8712_init_recv_priv() and also r8712_init_recv_priv()
> > just returns silently if they fail to allocate memory. Change their
> > return type to int and add necessary checks and handling if they return
> > -ENOMEM
> >
> > Signed-off-by: Nam Cao <namcaov@gmail.com>
> > ---
> > drivers/staging/rtl8712/os_intfs.c | 3 ++-
> > drivers/staging/rtl8712/recv_osdep.h | 8 ++++----
> > drivers/staging/rtl8712/rtl8712_recv.c | 7 ++++---
> > drivers/staging/rtl8712/rtl871x_recv.c | 13 +++++++++----
> > 4 files changed, 19 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> > index 003e97205124..47d7d998fa86 100644
> > --- a/drivers/staging/rtl8712/os_intfs.c
> > +++ b/drivers/staging/rtl8712/os_intfs.c
> > @@ -309,7 +309,8 @@ int r8712_init_drv_sw(struct _adapter *padapter)
> > if (ret)
> > return ret;
> > _r8712_init_xmit_priv(&padapter->xmitpriv, padapter);
> > - _r8712_init_recv_priv(&padapter->recvpriv, padapter);
> > + ret = _r8712_init_recv_priv(&padapter->recvpriv, padapter);
> > + return ret;
>
> If statement missing.

Probably a rebase mistake, the if statement is there in the last patch.
Will send a v2 nonetheless, thank you for noticing this.

Best regards,
Nam

\
 
 \ /
  Last update: 2022-10-25 10:54    [W:0.048 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site