Messages in this thread | | | From | "Chang, Junxiao" <> | Subject | RE: [PATCH net-next 1/2] net: stmmac: fix unsafe MTL DMA macro | Date | Tue, 25 Oct 2022 04:58:12 +0000 |
| |
Thank you for reviewing it. There is no real issue if this macro only be used in stmmac driver and parameter is not function or "i++".
I will squash these two patches.
Regards, Junxiao
-----Original Message----- From: Jakub Kicinski <kuba@kernel.org> Sent: Tuesday, October 25, 2022 12:00 PM To: Chang, Junxiao <junxiao.chang@intel.com> Cc: peppe.cavallaro@st.com; alexandre.torgue@foss.st.com; joabreu@synopsys.com; davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; mcoquelin.stm32@gmail.com; Joao.Pinto@synopsys.com; netdev@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: stmmac: fix unsafe MTL DMA macro
On Fri, 21 Oct 2022 19:47:10 +0800 Junxiao Chang wrote: > Macro like "#define abc(x) (x, x)" is unsafe which might introduce > side effects. Each MTL RxQ DMA channel mask is 4 bits, so using (0xf > << chan) instead of GENMASK(x + 3, x) to avoid unsafe macro. > > Fixes: d43042f4da3e ("net: stmmac: mapping mtl rx to dma channel")
You need to point out an existing usage where this is causing problems, otherwise this is not a fix.
And squash the two patches together, it's going to be easier to review.
| |