Messages in this thread | | | Date | Tue, 25 Oct 2022 09:44:24 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH 4/7] can: mcan: enable peripheral clk to access mram |
| |
On 21.10.2022 15:28:30, Vivek Yadav wrote: > When we try to access the mcan message ram addresses, make sure hclk is > not gated by any other drivers or disabled. Enable the clock (hclk) before > accessing the mram and disable it after that. > > This is required in case if by-default hclk is gated.
From my point of view it makes no sense to init the RAM during probe. Can you move the init_ram into the m_can_chip_config() function? The clocks should be enabled then.
Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |