Messages in this thread | | | Date | Wed, 26 Oct 2022 02:17:13 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] pwm: Add missing dummy for devm_pwmchip_add() |
| |
Hello Geert,
On Tue, Oct 25, 2022 at 04:03:42PM +0200, Geert Uytterhoeven wrote: > The PWM subsystem supports compile-testing if CONFIG_PWM is disabled. > However, no dummy is provided for devm_pwmchip_add(), which may lead to > build failures. > > Fixes: bcda91bf86c1ff76 ("pwm: Add a device-managed function to add PWM chips") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Is this a problem that today yields a failure to compile? As of v6.1-rc1 and also in next all callers are below drivers/pwm/ which isn't included in the build without PWM=y.
Am I missing something or is this just preparing that one of the drivers that doesn't live in drivers/pwm might call devm_pwmchip_add in the future? In that case I wouldn't add that Fixes: line (and also oppose to backporting that commit to stable).
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |