lkml.org 
[lkml]   [2022]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] reiserfs: journal: Increase jl pointer check
Date
On Tue, 25 Oct 2022, Li zeming wrote:
> If kzalloc fails to allocate the jl pointer, NULL is returned directly.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> fs/reiserfs/journal.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 94addfcefede..d64e9de126c1 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -2569,6 +2569,9 @@ static struct reiserfs_journal_list *alloc_journal_list(struct super_block *s)
> struct reiserfs_journal_list *jl;
> jl = kzalloc(sizeof(struct reiserfs_journal_list),
> GFP_NOFS | __GFP_NOFAIL);
> + if (!jl)
> + return NULL;
> +

What do you think the __GFP_NOFAIL flag might mean?

NeilBrown



> INIT_LIST_HEAD(&jl->j_list);
> INIT_LIST_HEAD(&jl->j_working_list);
> INIT_LIST_HEAD(&jl->j_tail_bh_list);
> --
> 2.18.2
>
>

\
 
 \ /
  Last update: 2022-10-25 23:31    [W:0.082 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site