Messages in this thread | | | Date | Tue, 25 Oct 2022 20:37:39 +0200 | Subject | Re: [PATCH v2 0/4] staging: rtl8712: clean up dynamic memory management | From | Philipp Hortmann <> |
| |
On 10/25/22 11:12, Nam Cao wrote: > This driver is fine if memory allocation never fails. However it does not > handle allocation failure well. This can either lead to memory leak, or > unallocated buffers being used. > > v2: Add a missing if statement, as noticed by Dan Carpenter > > Nam Cao (4): > Revert "staging: r8712u: Tracking kmemleak false positives." > staging: rtl8712: check for alloc fail in _r8712_init_recv_priv() > staging: rtl8712: check for return value of _r8712_init_xmit_priv() > staging: rtl8712: fix potential memory leak > > drivers/staging/rtl8712/os_intfs.c | 27 +++++++++++++++++++++----- > drivers/staging/rtl8712/recv_osdep.h | 8 ++++---- > drivers/staging/rtl8712/rtl8712_recv.c | 7 ++++--- > drivers/staging/rtl8712/rtl871x_recv.c | 16 ++++++++------- > 4 files changed, 39 insertions(+), 19 deletions(-) >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
| |