Messages in this thread | | | Date | Tue, 25 Oct 2022 09:30:28 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 04/11] media: cedrus: Add helper for checking capabilities |
| |
On Mon, Oct 24, 2022 at 10:15:08PM +0200, Jernej Skrabec wrote: > There is several different Cedrus cores with varying capabilities, so > some operations like listing formats depends on checks if feature is > supported or not. > > Currently check for capabilities is only in format enumeration helper, > but it will be used also elsewhere later. Let's convert this check to > helper and while at it, also simplify it. There is no need to check if > capability mask is zero, condition will still work properly.
Sure. That's true. Out of curiousity, can cedrus_formats[i].capabilities be zero? Because it feels like that's what should be checked.
regards, dan carpenter
| |