Messages in this thread Patch in this message | | | From | Kang Minchul <> | Subject | [PATCH v3 2/4] staging: r8188eu: remove unnecessary vaiable in rtw_recv | Date | Wed, 26 Oct 2022 02:06:19 +0900 |
| |
Return _SUCCESS directly instead of storing it in a variable. This can prevent cocci warning as follows:
Unneeded variable: "ret". Return "_SUCCESS" on line 1516
Signed-off-by: Kang Minchul <tegongkang@gmail.com> --- v2 -> v3: rollback to v1 because v2 caused error by kernel test robot v1 -> v2: made amsdu_to_msdu into void function
drivers/staging/r8188eu/core/rtw_recv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c index bb5c3b3888e0..9e98aea09583 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -1415,7 +1415,6 @@ static int amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prframe) struct recv_priv *precvpriv = &padapter->recvpriv; struct __queue *pfree_recv_queue = &precvpriv->free_recv_queue; - int ret = _SUCCESS; nr_subframes = 0; @@ -1513,7 +1512,7 @@ static int amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prframe) prframe->len = 0; rtw_free_recvframe(prframe, pfree_recv_queue);/* free this recv_frame */ - return ret; + return _SUCCESS; } static bool check_indicate_seq(struct recv_reorder_ctrl *preorder_ctrl, u16 seq_num) -- 2.34.1
| |