Messages in this thread | | | Date | Tue, 25 Oct 2022 18:01:32 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] ALSA/ASoC: replace ternary operator with min() |
| |
On Tue, Oct 25, 2022 at 10:56:11PM +0800, wangkailong@jari.cn wrote: > Fix the following coccicheck warning: > > sound/soc/soc-ops.c:817: WARNING opportunity for min()
> kfree(uctl); > - return err < 0 ? err : 0; > + return min(err, 0);
I don't think this is a good warning, while I'm no big fan of the ternery operator the new code is less clear about the intent than the old code. [unhandled content-type:application/pgp-signature] | |