lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 025/210] dmaengine: xilinx_dma: Report error in case of dma_set_mask_and_coherent API failure
    Date
    From: Swati Agarwal <swati.agarwal@xilinx.com>

    [ Upstream commit 8f2b6bc79c32f0fa60df000ae387a790ec80eae9 ]

    The driver does not handle the failure case while calling
    dma_set_mask_and_coherent API.

    In case of failure, capture the return value of API and then report an
    error.

    Addresses-coverity: Unchecked return value (CHECKED_RETURN)

    Signed-off-by: Swati Agarwal <swati.agarwal@xilinx.com>
    Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
    Link: https://lore.kernel.org/r/20220817061125.4720-4-swati.agarwal@xilinx.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/xilinx/xilinx_dma.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
    index 9319349e69d2..b4d00bc461db 100644
    --- a/drivers/dma/xilinx/xilinx_dma.c
    +++ b/drivers/dma/xilinx/xilinx_dma.c
    @@ -2585,7 +2585,11 @@ static int xilinx_dma_probe(struct platform_device *pdev)
    xdev->ext_addr = false;

    /* Set the dma mask bits */
    - dma_set_mask_and_coherent(xdev->dev, DMA_BIT_MASK(addr_width));
    + err = dma_set_mask_and_coherent(xdev->dev, DMA_BIT_MASK(addr_width));
    + if (err < 0) {
    + dev_err(xdev->dev, "DMA mask error %d\n", err);
    + goto disable_clks;
    + }

    /* Initialize the DMA engine */
    xdev->common.dev = &pdev->dev;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 14:40    [W:4.148 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site