lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: wlan-ng: remove commented debug printk messages
On Mon, Oct 24, 2022 at 10:08:00AM +0700, Bagas Sanjaya wrote:
> On 10/23/22 21:13, Greg KH wrote:
> >>> @@ -1007,7 +986,6 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> >>> wlandev->rx.cfack_cfpoll++;
> >>> break;
> >>> default:
> >>> - /* printk("unknown"); */
> >>> wlandev->rx.data_unknown++;
> >>> break;
> >>> }
> >>
> >> Shouldn't these printks be guarded under CONFIG_DEBUG_KERNEL instead?
> >
> > No, they should just be removed as was done here.
> >
>
> What if in case of debugging without these printks?

I can not parse this line, sorry.

\
 
 \ /
  Last update: 2022-10-24 09:44    [W:0.041 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site