lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 013/159] selftests: Fix the if conditions of in test_extra_filter()
    Date
    From: Wang Yufen <wangyufen@huawei.com>

    [ Upstream commit bc7a319844891746135dc1f34ab9df78d636a3ac ]

    The socket 2 bind the addr in use, bind should fail with EADDRINUSE. So
    if bind success or errno != EADDRINUSE, testcase should be failed.

    Fixes: 3ca8e4029969 ("soreuseport: BPF selection functional test")
    Signed-off-by: Wang Yufen <wangyufen@huawei.com>
    Link: https://lore.kernel.org/r/1663916557-10730-1-git-send-email-wangyufen@huawei.com
    Signed-off-by: Paolo Abeni <pabeni@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/net/reuseport_bpf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/net/reuseport_bpf.c b/tools/testing/selftests/net/reuseport_bpf.c
    index b5277106df1f..b0cc082fbb84 100644
    --- a/tools/testing/selftests/net/reuseport_bpf.c
    +++ b/tools/testing/selftests/net/reuseport_bpf.c
    @@ -330,7 +330,7 @@ static void test_extra_filter(const struct test_params p)
    if (bind(fd1, addr, sockaddr_size()))
    error(1, errno, "failed to bind recv socket 1");

    - if (!bind(fd2, addr, sockaddr_size()) && errno != EADDRINUSE)
    + if (!bind(fd2, addr, sockaddr_size()) || errno != EADDRINUSE)
    error(1, errno, "bind socket 2 should fail with EADDRINUSE");

    free(addr);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 13:55    [W:3.926 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site