Messages in this thread | | | Date | Tue, 25 Oct 2022 10:55:15 +0800 | Subject | Re: [PATCH 2/2] f2fs: remove batched_trim_sections node | From | Chao Yu <> |
| |
On 2022/10/21 23:38, Yangtao Li wrote: > This testing sysfs node has been deprecated for a long time, > let's remove it.
Can you please merge this patch w/
[PATCH 1/2] f2fs: fix to correct invalid batched_trim_sections node
> > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > fs/f2fs/f2fs.h | 3 --- > fs/f2fs/sysfs.c | 5 ----- > 2 files changed, 8 deletions(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index e6355a5683b7..9c480835adab 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -1062,9 +1062,6 @@ struct f2fs_sm_info { > /* a threshold to reclaim prefree segments */ > unsigned int rec_prefree_segments; > > - /* for batched trimming */ > - unsigned int trim_sections; /* # of sections to trim */ > - > struct list_head sit_entry_set; /* sit entry set list */ > > unsigned int ipu_policy; /* in-place-update policy */ > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > index 3005e2783a25..926b7a844362 100644 > --- a/fs/f2fs/sysfs.c > +++ b/fs/f2fs/sysfs.c > @@ -488,9 +488,6 @@ static ssize_t __sbi_store(struct f2fs_attr *a, > return -EINVAL; > } > > - if (!strcmp(a->attr.name, "batched_trim_sections")) > - return -EINVAL; > - > if (!strcmp(a->attr.name, "gc_urgent")) { > if (t == 0) { > sbi->gc_mode = GC_NORMAL; > @@ -790,7 +787,6 @@ F2FS_RW_ATTR(DCC_INFO, discard_cmd_control, mid_discard_issue_time, mid_discard_ > F2FS_RW_ATTR(DCC_INFO, discard_cmd_control, max_discard_issue_time, max_discard_issue_time); > F2FS_RW_ATTR(DCC_INFO, discard_cmd_control, discard_granularity, discard_granularity); > F2FS_RW_ATTR(RESERVED_BLOCKS, f2fs_sb_info, reserved_blocks, reserved_blocks); > -F2FS_RW_ATTR(SM_INFO, f2fs_sm_info, batched_trim_sections, trim_sections); > F2FS_RW_ATTR(SM_INFO, f2fs_sm_info, ipu_policy, ipu_policy); > F2FS_RW_ATTR(SM_INFO, f2fs_sm_info, min_ipu_util, min_ipu_util); > F2FS_RW_ATTR(SM_INFO, f2fs_sm_info, min_fsync_blocks, min_fsync_blocks); > @@ -919,7 +915,6 @@ static struct attribute *f2fs_attrs[] = { > ATTR_LIST(max_discard_issue_time), > ATTR_LIST(discard_granularity), > ATTR_LIST(pending_discard), > - ATTR_LIST(batched_trim_sections), > ATTR_LIST(ipu_policy), > ATTR_LIST(min_ipu_util), > ATTR_LIST(min_fsync_blocks),
| |