lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe
From
Date


> On Oct 24, 2022, at 20:00, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote:
>> The commit 1149108e2fbf ("can: mscan: improve clock API use
>> ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add
>
> Strange indentation. Why the '")' part can't be on the previous line?

:/ it is automatically done by vim in `git commit -a -s -e`. I can adjust this part in v2 patch.

>
>> put_clock in the error handling code.
>>
>> Fix this bug by adding put_clock in the error handling code.
>
> --
> With Best Regards,
> Andy Shevchenko
>

\
 
 \ /
  Last update: 2022-10-25 04:33    [W:0.117 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site