lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v15 2/3] virt: Add TDX guest driver


On 10/24/22 6:54 AM, Greg Kroah-Hartman wrote:
>>>>>> You are allowing userspace to spam the kernel logs, please do not do
>>>>>> that.
>>>>> Added it to help userspace understand the reason for the failure (only for
>>>>> the cases like request param issues and TDCALL failure). Boris recommended
>>>>> adding it in the previous review.
>>>> Again, you just created a vector for userspace to spam the kernel log.
>>>> No kernel driver should ever do that.
>>>>
>>> Brois, any comments? Do you also agree?
>>>
>> Maybe dev_err_once() does the job?
> That does not make any sense when the userspace input can be different
> each time.
>
> This is just yet-another-ioctl, there's nothing special about it.
> Return an error for invalid input and don't log anything. Worst case,
> make it a dev_dbg() call if you really really really want to see it.

It is a nice to have debug info, but not very important. So I will remove it.

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer

\
 
 \ /
  Last update: 2022-10-25 03:04    [W:0.066 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site