lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] net: ipa: fix v3.5.1 resource limit max values
From
On 10/24/22 4:03 PM, Caleb Connolly wrote:
> Some resource limits on IPA v3.5.1 have their max values set to
> 255, this causes a few splats in ipa_reg_encode and prevents the
> IPA from booting properly. The limits are all 6 bits wide so
> adjust the max values to 63.
>
> Fixes: 1c418c4a929c ("net: ipa: define resource group/type IPA register fields")
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Thanks Caleb, this looks good.

David et al, in case it isn't obvious, this is for net/master,
for back-port (only to 6.0.y).

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
> V1: https://lore.kernel.org/netdev/20221024165636.3979249-1-caleb.connolly@linaro.org/
> Changes since v1:
> * Apply the correct fix for v3.1 which has the opposite issue where the masks
> are wrong rather than the values.
> * Split into two patches
> ---
> drivers/net/ipa/data/ipa_data-v3.5.1.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ipa/data/ipa_data-v3.5.1.c b/drivers/net/ipa/data/ipa_data-v3.5.1.c
> index 383ef1890065..42f2c88a92d4 100644
> --- a/drivers/net/ipa/data/ipa_data-v3.5.1.c
> +++ b/drivers/net/ipa/data/ipa_data-v3.5.1.c
> @@ -179,10 +179,10 @@ static const struct ipa_gsi_endpoint_data ipa_gsi_endpoint_data[] = {
> static const struct ipa_resource ipa_resource_src[] = {
> [IPA_RESOURCE_TYPE_SRC_PKT_CONTEXTS] = {
> .limits[IPA_RSRC_GROUP_SRC_LWA_DL] = {
> - .min = 1, .max = 255,
> + .min = 1, .max = 63,
> },
> .limits[IPA_RSRC_GROUP_SRC_UL_DL] = {
> - .min = 1, .max = 255,
> + .min = 1, .max = 63,
> },
> .limits[IPA_RSRC_GROUP_SRC_UC_RX_Q] = {
> .min = 1, .max = 63,

\
 
 \ /
  Last update: 2022-10-25 01:16    [W:0.063 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site