lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 463/530] ARM: dts: imx7d-sdb: config the max pressure for tsc2046
    Date
    From: Haibo Chen <haibo.chen@nxp.com>

    [ Upstream commit e7c4ebe2f9cd68588eb24ba4ed122e696e2d5272 ]

    Use the general touchscreen method to config the max pressure for
    touch tsc2046(data sheet suggest 8 bit pressure), otherwise, for
    ABS_PRESSURE, when config the same max and min value, weston will
    meet the following issue,

    [17:19:39.183] event1 - ADS7846 Touchscreen: is tagged by udev as: Touchscreen
    [17:19:39.183] event1 - ADS7846 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE
    [17:19:39.183] event1 - ADS7846 Touchscreen: was rejected
    [17:19:39.183] event1 - not using input device '/dev/input/event1'

    This will then cause the APP weston-touch-calibrator can't list touch devices.

    root@imx6ul7d:~# weston-touch-calibrator
    could not load cursor 'dnd-move'
    could not load cursor 'dnd-copy'
    could not load cursor 'dnd-none'
    No devices listed.

    And accroding to binding Doc, "ti,x-max", "ti,y-max", "ti,pressure-max"
    belong to the deprecated properties, so remove them. Also for "ti,x-min",
    "ti,y-min", "ti,x-plate-ohms", the value set in dts equal to the default
    value in driver, so are redundant, also remove here.

    Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
    Signed-off-by: Shawn Guo <shawnguo@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/imx7d-sdb.dts | 7 +------
    1 file changed, 1 insertion(+), 6 deletions(-)

    diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
    index e5f1bdbe7992..4e1a6cde90fe 100644
    --- a/arch/arm/boot/dts/imx7d-sdb.dts
    +++ b/arch/arm/boot/dts/imx7d-sdb.dts
    @@ -206,12 +206,7 @@
    interrupt-parent = <&gpio2>;
    interrupts = <29 0>;
    pendown-gpio = <&gpio2 29 GPIO_ACTIVE_HIGH>;
    - ti,x-min = /bits/ 16 <0>;
    - ti,x-max = /bits/ 16 <0>;
    - ti,y-min = /bits/ 16 <0>;
    - ti,y-max = /bits/ 16 <0>;
    - ti,pressure-max = /bits/ 16 <0>;
    - ti,x-plate-ohms = /bits/ 16 <400>;
    + touchscreen-max-pressure = <255>;
    wakeup-source;
    };
    };
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-25 00:53    [W:4.070 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site