lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/11] mm/damon/sysfs: split out kdamond-independent schemes stats update logic into a new function
    Date
    'damon_sysfs_schemes_update_stats()' is coupled with both
    damon_sysfs_kdamond and damon_sysfs_schemes. It's a wide range of types
    dependency. It makes splitting the logics a little bit distracting.
    Split the function so that each function is coupled with smaller range
    of types.

    Signed-off-by: SeongJae Park <sj@kernel.org>
    ---
    mm/damon/sysfs.c | 35 +++++++++++++++++++++--------------
    1 file changed, 21 insertions(+), 14 deletions(-)

    diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
    index 129743292e17..082c55e68e0e 100644
    --- a/mm/damon/sysfs.c
    +++ b/mm/damon/sysfs.c
    @@ -2204,6 +2204,25 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx)
    mutex_unlock(&ctx->kdamond_lock);
    }

    +static void damon_sysfs_schemes_update_stats(
    + struct damon_sysfs_schemes *sysfs_schemes,
    + struct damon_ctx *ctx)
    +{
    + struct damos *scheme;
    + int schemes_idx = 0;
    +
    + damon_for_each_scheme(scheme, ctx) {
    + struct damon_sysfs_stats *sysfs_stats;
    +
    + sysfs_stats = sysfs_schemes->schemes_arr[schemes_idx++]->stats;
    + sysfs_stats->nr_tried = scheme->stat.nr_tried;
    + sysfs_stats->sz_tried = scheme->stat.sz_tried;
    + sysfs_stats->nr_applied = scheme->stat.nr_applied;
    + sysfs_stats->sz_applied = scheme->stat.sz_applied;
    + sysfs_stats->qt_exceeds = scheme->stat.qt_exceeds;
    + }
    +}
    +
    /*
    * damon_sysfs_upd_schemes_stats() - Update schemes stats sysfs files.
    * @kdamond: The kobject wrapper that associated to the kdamond thread.
    @@ -2216,23 +2235,11 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx)
    static int damon_sysfs_upd_schemes_stats(struct damon_sysfs_kdamond *kdamond)
    {
    struct damon_ctx *ctx = kdamond->damon_ctx;
    - struct damon_sysfs_schemes *sysfs_schemes;
    - struct damos *scheme;
    - int schemes_idx = 0;

    if (!ctx)
    return -EINVAL;
    - sysfs_schemes = kdamond->contexts->contexts_arr[0]->schemes;
    - damon_for_each_scheme(scheme, ctx) {
    - struct damon_sysfs_stats *sysfs_stats;
    -
    - sysfs_stats = sysfs_schemes->schemes_arr[schemes_idx++]->stats;
    - sysfs_stats->nr_tried = scheme->stat.nr_tried;
    - sysfs_stats->sz_tried = scheme->stat.sz_tried;
    - sysfs_stats->nr_applied = scheme->stat.nr_applied;
    - sysfs_stats->sz_applied = scheme->stat.sz_applied;
    - sysfs_stats->qt_exceeds = scheme->stat.qt_exceeds;
    - }
    + damon_sysfs_schemes_update_stats(
    + kdamond->contexts->contexts_arr[0]->schemes, ctx);
    return 0;
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2022-10-25 00:30    [W:2.600 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site