| Date | Mon, 24 Oct 2022 21:06:57 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v3 03/23] filemap: Convert __filemap_fdatawait_range() to use filemap_get_folios_tag() |
| |
On Mon, Oct 17, 2022 at 01:24:31PM -0700, Vishal Moola (Oracle) wrote: > Converted function to use folios. This is in preparation for the removal > of find_get_pages_range_tag().
Yes, it is, but this patch also has some nice advantages of its own:
- Removes a call to wait_on_page_writeback(), which removes a call to compound_head() - Removes a call to ClearPageError(), which removes another call to compound_head() - Removes a call to pagevec_release(), which will eventually remove a third call to compound_head() (it doesn't today, but one day ...)
So you can definitely say that it removes 50 bytes of text and two calls to compound_head(). And that way, this patch justifies its existance by itself ;-)
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
|