Messages in this thread | | | Date | Mon, 24 Oct 2022 15:17:14 +0100 | From | Andre Przywara <> | Subject | Re: [PATCH v2 09/10] dt-binding: arm: sunxi: add compatible strings for PopStick v1.1 |
| |
On Wed, 12 Oct 2022 13:56:01 +0800 Icenowy Zheng <uwu@icenowy.me> wrote:
Hi Icenowy,
> SourceParts PopStick is a F1C200s-based stick-shaped SBC. > > Add a compatible string list for its v1.1 version (the first public > one).
If v1.0 (or anything prior) never made it to the outside world, I don't think we need to mention that in the public bindings. In general Linux seems to discourage support for unreleased hardware, so I think you can just drop the "sourceparts,popstick-v1.1" name.
Cheers, Andre
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me> > --- > New patch introduced in v2. > > Documentation/devicetree/bindings/arm/sunxi.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > index 3ad1cd50e3fe..c6e0ad7f461d 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -807,6 +807,13 @@ properties: > - const: sinlinx,sina33 > - const: allwinner,sun8i-a33 > > + - description: SourceParts PopStick v1.1 > + items: > + - const: sourceparts,popstick-v1.1 > + - const: sourceparts,popstick > + - const: allwinner,suniv-f1c200s > + - const: allwinner,suniv-f1c100s > + > - description: SL631 Action Camera with IMX179 > items: > - const: allwinner,sl631-imx179
| |