lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 127/255] clk: tegra: Fix refcount leak in tegra114_clock_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit db16a80c76ea395766913082b1e3f939dde29b2c ]

    of_find_matching_node() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 2cb5efefd6f7 ("clk: tegra: Implement clocks for Tegra114")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220523143834.7587-1-linmq006@gmail.com
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/tegra/clk-tegra114.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
    index 4efcaaf51b3a..586b091651dd 100644
    --- a/drivers/clk/tegra/clk-tegra114.c
    +++ b/drivers/clk/tegra/clk-tegra114.c
    @@ -1337,6 +1337,7 @@ static void __init tegra114_clock_init(struct device_node *np)
    }

    pmc_base = of_iomap(node, 0);
    + of_node_put(node);
    if (!pmc_base) {
    pr_err("Can't map pmc registers\n");
    WARN_ON(1);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 22:39    [W:4.102 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site