lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 251/530] soc: qcom: smem_state: Add refcounting for the state->of_node
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 90681f53b9381c23ff7762a3b13826d620c272de ]

    In qcom_smem_state_register() and qcom_smem_state_release(), we
    should better use of_node_get() and of_node_put() for the reference
    creation and destruction of 'device_node'.

    Fixes: 9460ae2ff308 ("soc: qcom: Introduce common SMEM state machine code")
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20220721135217.1301039-2-windhl@126.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/qcom/smem_state.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/soc/qcom/smem_state.c b/drivers/soc/qcom/smem_state.c
    index 31faf4aa868e..e848cc9a3cf8 100644
    --- a/drivers/soc/qcom/smem_state.c
    +++ b/drivers/soc/qcom/smem_state.c
    @@ -136,6 +136,7 @@ static void qcom_smem_state_release(struct kref *ref)
    struct qcom_smem_state *state = container_of(ref, struct qcom_smem_state, refcount);

    list_del(&state->list);
    + of_node_put(state->of_node);
    kfree(state);
    }

    @@ -205,7 +206,7 @@ struct qcom_smem_state *qcom_smem_state_register(struct device_node *of_node,

    kref_init(&state->refcount);

    - state->of_node = of_node;
    + state->of_node = of_node_get(of_node);
    state->ops = *ops;
    state->priv = priv;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 22:18    [W:3.169 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site