Messages in this thread | | | Date | Mon, 24 Oct 2022 20:29:26 +0200 | Subject | Re: [PATCH] video: fbdev: sis: use explicitly signed char | From | Helge Deller <> |
| |
On 10/24/22 18:29, Jason A. Donenfeld wrote: > With char becoming unsigned by default, and with `char` alone being > ambiguous and based on architecture, signed chars need to be marked > explicitly as such. This fixes warnings like: > > drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned > > Cc: Thomas Winischhofer <thomas@winischhofer.net> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Helge Deller <deller@gmx.de> > Cc: linux-usb@vger.kernel.org > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Applied to linux-fbdev git tree.
Thanks, Helge
> --- > drivers/usb/misc/sisusbvga/sisusb_struct.h | 2 +- > drivers/video/fbdev/sis/vstruct.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/misc/sisusbvga/sisusb_struct.h b/drivers/usb/misc/sisusbvga/sisusb_struct.h > index 3df64d2a9d43..a86032a26d36 100644 > --- a/drivers/usb/misc/sisusbvga/sisusb_struct.h > +++ b/drivers/usb/misc/sisusbvga/sisusb_struct.h > @@ -91,7 +91,7 @@ struct SiS_Ext { > unsigned char VB_ExtTVYFilterIndex; > unsigned char VB_ExtTVYFilterIndexROM661; > unsigned char REFindex; > - char ROMMODEIDX661; > + signed char ROMMODEIDX661; > }; > > struct SiS_Ext2 { > diff --git a/drivers/video/fbdev/sis/vstruct.h b/drivers/video/fbdev/sis/vstruct.h > index ea94d214dcff..d7a14e63ba5a 100644 > --- a/drivers/video/fbdev/sis/vstruct.h > +++ b/drivers/video/fbdev/sis/vstruct.h > @@ -148,7 +148,7 @@ struct SiS_Ext { > unsigned char VB_ExtTVYFilterIndex; > unsigned char VB_ExtTVYFilterIndexROM661; > unsigned char REFindex; > - char ROMMODEIDX661; > + signed char ROMMODEIDX661; > }; > > struct SiS_Ext2 {
| |