lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rft, PATCH v1 4/4] kernel.h: Split out ARRAY_SZIE()
On Mon, Oct 24, 2022 at 07:05:18PM +0300, Andy Shevchenko wrote:
> On Mon, Oct 24, 2022 at 06:44:50PM +0300, Alexey Dobriyan wrote:
> > > include/linux/array_size.h | 13 +++++++++++++
> >
> > All of this is pessimisation unless you're removing
> >
> > +#include <linux/array_size.h>
> >
> > from kernel.h which you aren't doing.
> >
> > container_of.h is just as silly.
> >
> > kernel.h might need _some_ cleanup (like panic and tainted stuff) which
> > is rarely used but ARRAY_SIZE()?
>
> Are you suggesting to slow down compilation with inclusion of tons of unneeded
> stuff in the zillions of drivers?
>
> Or you are talking that we need to abandon most of the headers and combine
> everything into kernel.h? I think this is what is silly.

It hard to escape kernel.h so you will be including it anyway.
Unless you delete, say, kstrtox.h from kernel.h, it is pointless busywork.

\
 
 \ /
  Last update: 2022-10-24 21:52    [W:0.107 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site