Messages in this thread | | | Date | Mon, 24 Oct 2022 12:26:53 -0400 | Subject | Re: [PATCH 2/3] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies | From | Krzysztof Kozlowski <> |
| |
On 24/10/2022 11:06, Nícolas F. R. A. Prado wrote: > On Sat, Oct 22, 2022 at 12:39:56PM -0400, Krzysztof Kozlowski wrote: >> On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: >>> The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties >>> for them. >>> >>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >>> --- >>> >>> Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml >>> index ea53a55015c4..ca1037e76f96 100644 >>> --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml >>> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml >>> @@ -90,6 +90,10 @@ properties: >>> "#sound-dai-cells": >>> const: 0 >>> >>> + AVDD-supply: true >>> + >>> + MICVDD-supply: true >>> + >> >> How about keeping some order in the list of properties? > > The current properties don't seem to follow any particular order and keeping the > supplies grouped together seemed reasonable. What ordering do you suggest?
That's true... :/
Best regards, Krzysztof
| |