lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRE: [PATCH v11 1/9] mm: allow multiple error returns in try_grab_page()
    Logan Gunthorpe wrote:
    > In order to add checks for P2PDMA memory into try_grab_page(), expand
    > the error return from a bool to an int/error code. Update all the
    > callsites handle change in usage.
    >
    > Also remove the WARN_ON_ONCE() call at the callsites seeing there
    > already is a WARN_ON_ONCE() inside the function if it fails.

    Looks good,

    Reviewed-by: Dan Williams <dan.j.williams@intel.com>

    \
     
     \ /
      Last update: 2022-10-24 20:01    [W:5.506 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site