lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 109/255] memory: of: Fix refcount leak bug in of_get_ddr_timings()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 05215fb32010d4afb68fbdbb4d237df6e2d4567b ]

    We should add the of_node_put() when breaking out of
    for_each_child_of_node() as it will automatically increase
    and decrease the refcount.

    Fixes: e6b42eb6a66c ("memory: emif: add device tree support to emif driver")
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Link: https://lore.kernel.org/r/20220719085640.1210583-1-windhl@126.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/memory/of_memory.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c
    index 46539b27a3fb..835754304a7f 100644
    --- a/drivers/memory/of_memory.c
    +++ b/drivers/memory/of_memory.c
    @@ -132,6 +132,7 @@ const struct lpddr2_timings *of_get_ddr_timings(struct device_node *np_ddr,
    for_each_child_of_node(np_ddr, np_tim) {
    if (of_device_is_compatible(np_tim, tim_compat)) {
    if (of_do_get_timings(np_tim, &timings[i])) {
    + of_node_put(np_tim);
    devm_kfree(dev, timings);
    goto default_timings;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 18:44    [W:2.052 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site