lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 124/390] spi: dw: Fix PM disable depth imbalance in dw_spi_bt1_probe
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit 618d815fc93477b1675878f3c04ff32657cc18b4 ]

    The pm_runtime_enable will increase power disable depth. Thus
    a pairing decrement is needed on the error handling path to
    keep it balanced according to context.

    Fixes:abf00907538e2 ("spi: dw: Add Baikal-T1 SPI Controller glue driver")

    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20220924121310.78331-3-zhangqilong3@huawei.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-dw-bt1.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/spi/spi-dw-bt1.c b/drivers/spi/spi-dw-bt1.c
    index bc9d5eab3c58..8f6a1af14456 100644
    --- a/drivers/spi/spi-dw-bt1.c
    +++ b/drivers/spi/spi-dw-bt1.c
    @@ -293,8 +293,10 @@ static int dw_spi_bt1_probe(struct platform_device *pdev)
    pm_runtime_enable(&pdev->dev);

    ret = dw_spi_add_host(&pdev->dev, dws);
    - if (ret)
    + if (ret) {
    + pm_runtime_disable(&pdev->dev);
    goto err_disable_clk;
    + }

    platform_set_drvdata(pdev, dwsbt1);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 18:12    [W:5.987 / U:1.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site