lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 117/390] wifi: rtl8xxxu: Remove copy-paste leftover in gen2_update_rate_mask
    Date
    From: Bitterblue Smith <rtl8821cerfe2@gmail.com>

    [ Upstream commit d5350756c03cdf18696295c6b11d7acc4dbf825c ]

    It looks like a leftover from copying rtl8xxxu_update_rate_mask,
    which is used with the gen1 chips.

    It wasn't causing any problems for my RTL8188FU test device, but it's
    clearly a mistake, so remove it.

    Fixes: f653e69009c6 ("rtl8xxxu: Implement basic 8723b specific update_rate_mask() function")
    Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
    Signed-off-by: Kalle Valo <kvalo@kernel.org>
    Link: https://lore.kernel.org/r/d5544fe8-9798-28f1-54bd-6839a1974b10@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
    index 8668b03bd8c7..7818a7ea0498 100644
    --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
    +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
    @@ -4338,15 +4338,14 @@ void rtl8xxxu_gen2_update_rate_mask(struct rtl8xxxu_priv *priv,
    h2c.b_macid_cfg.ramask2 = (ramask >> 16) & 0xff;
    h2c.b_macid_cfg.ramask3 = (ramask >> 24) & 0xff;

    - h2c.ramask.arg = 0x80;
    h2c.b_macid_cfg.data1 = rateid;
    if (sgi)
    h2c.b_macid_cfg.data1 |= BIT(7);

    h2c.b_macid_cfg.data2 = bw;

    - dev_dbg(&priv->udev->dev, "%s: rate mask %08x, arg %02x, size %zi\n",
    - __func__, ramask, h2c.ramask.arg, sizeof(h2c.b_macid_cfg));
    + dev_dbg(&priv->udev->dev, "%s: rate mask %08x, rateid %02x, sgi %d, size %zi\n",
    + __func__, ramask, rateid, sgi, sizeof(h2c.b_macid_cfg));
    rtl8xxxu_gen2_h2c_cmd(priv, &h2c, sizeof(h2c.b_macid_cfg));
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 18:11    [W:6.636 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site