lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 221/390] mtd: devices: docg3: check the return value of devm_ioremap() in the probe
    Date
    From: William Dean <williamsukatube@gmail.com>

    [ Upstream commit 26e784433e6c65735cd6d93a8db52531970d9a60 ]

    The function devm_ioremap() in docg3_probe() can fail, so
    its return value should be checked.

    Fixes: 82402aeb8c81e ("mtd: docg3: Use devm_*() functions")
    Reported-by: Hacash Robot <hacashRobot@santino.com>
    Signed-off-by: William Dean <williamsukatube@gmail.com>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20220722091644.2937953-1-williamsukatube@163.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/devices/docg3.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
    index a030792115bc..fa42473d04c1 100644
    --- a/drivers/mtd/devices/docg3.c
    +++ b/drivers/mtd/devices/docg3.c
    @@ -1975,9 +1975,14 @@ static int __init docg3_probe(struct platform_device *pdev)
    dev_err(dev, "No I/O memory resource defined\n");
    return ret;
    }
    - base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE);

    ret = -ENOMEM;
    + base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE);
    + if (!base) {
    + dev_err(dev, "devm_ioremap dev failed\n");
    + return ret;
    + }
    +
    cascade = devm_kcalloc(dev, DOC_MAX_NBFLOORS, sizeof(*cascade),
    GFP_KERNEL);
    if (!cascade)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 18:05    [W:2.119 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site