lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 2/3] Input: add driver for Himax hx83112b touchscreen devices
From
Hi Jeff,

On Sun Oct 23, 2022 at 10:07 PM CEST, Jeff LaBundy wrote:
> Hi Job,
>
> Looks great; just a few tiny nits that I missed last time. Sorry
> about that!

No problem!

> > + ts->regmap = devm_regmap_init_i2c(client, &himax_regmap_config);
> > + error = PTR_ERR_OR_ZERO(ts->regmap);
> > + if (error) {
> > + dev_err(&client->dev,
>
> We already have a locally declared dev pointer which at this point is
> equal to &client->dev as well as &ts->client->dev, so we can just use
> that here instead.

Nice catch! Fixed this one and all others in v6.

> With those remaining points resolved:
>
> Reviewed-by: Jeff LaBundy <jeff@labundy.com>

Thanks! Added in v6.

Kind regards,
Job

\
 
 \ /
  Last update: 2022-10-24 17:49    [W:0.120 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site