Messages in this thread | | | Date | Mon, 24 Oct 2022 15:52:55 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v3] arm64: tegra: Add Tegra234 SDMMC1 device tree node |
| |
On Fri, Oct 07, 2022 at 10:29:41PM +0530, Prathamesh Shete wrote: > Add device tree node for Tegra234 SDMMC1 instance. > Add and enable SD card instance in device tree. > > Signed-off-by: Prathamesh Shete <pshete@nvidia.com> > --- > .../boot/dts/nvidia/tegra234-p3701-0000.dtsi | 7 +++ > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 60 +++++++++++++++++++ > 2 files changed, 67 insertions(+)
Applied, with some minor changes (see below).
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi [...] > + mmc@3400000 { > + compatible = "nvidia,tegra194-sdhci", "nvidia,tegra234-sdhci"; > + reg = <0x03400000 0x20000>; > + interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&bpmp TEGRA234_CLK_SDMMC1>, > + <&bpmp TEGRA234_CLK_SDMMC_LEGACY_TM>; > + clock-names = "sdhci", "tmclk"; > + assigned-clocks = <&bpmp TEGRA234_CLK_SDMMC1>, > + <&bpmp TEGRA234_CLK_PLLC4_MUXED>;
I've aligned these.
> + assigned-clock-parents = > + <&bpmp TEGRA234_CLK_PLLC4_MUXED>,
And put this on the previous line. checkpatch's character/row limit is 100, so let's use that.
> + <&bpmp TEGRA234_CLK_PLLC4_VCO_DIV2>;
> + resets = <&bpmp TEGRA234_RESET_SDMMC1>; > + reset-names = "sdhci"; > + interconnects = <&mc TEGRA234_MEMORY_CLIENT_SDMMCRA &emc>, > + <&mc TEGRA234_MEMORY_CLIENT_SDMMCWA &emc>; > + interconnect-names = "dma-mem", "write"; > + iommus = <&smmu_niso1 TEGRA234_SID_SDMMC1A>; > + pinctrl-names = "sdmmc-3v3", "sdmmc-1v8"; > + pinctrl-0 = <&sdmmc1_3v3>; > + pinctrl-1 = <&sdmmc1_1v8>; > + nvidia,pad-autocal-pull-up-offset-3v3-timeout = > + <0x07>; > + nvidia,pad-autocal-pull-down-offset-3v3-timeout = > + <0x07>; > + nvidia,pad-autocal-pull-up-offset-1v8-timeout = <0x06>; > + nvidia,pad-autocal-pull-down-offset-1v8-timeout = > + <0x07>;
Same here.
Thanks, Thierry [unhandled content-type:application/pgp-signature] | |