Messages in this thread | | | Date | Mon, 24 Oct 2022 15:32:52 +0200 | From | David Hildenbrand <> | Subject | Re: [PATCH v2 0/9] mm/ksm: break_ksm() cleanups and fixes |
| |
On 21.10.22 21:57, Andrew Morton wrote: > On Fri, 21 Oct 2022 12:11:32 +0200 David Hildenbrand <david@redhat.com> wrote: > >> This series cleans up and fixes break_ksm(). > > Quite a lot of fixups were needed merging this. I guess you couldn't > develop against mm-unstable because the v1 series was already in there.
Nowadays, I tend to send against mm-stable (I remember that was the suggestion). Usually it works because there are no conflicts -- this time there are probably quite some kvm unit test conflicts.
Feel free to ask me next time to rebase on XYZ so I can make you life easier ;)
> > For this reason I'll henceforth be more inclined to drop serieses when > I know a full resend is coming out.
Yes, good idea. While the fixup-patch process works for small adjustments, it's not a good fit for bigger changes, especially once involving new patches.
> > So please do let me know when a full resend is coming out.
Will do; I kind-of did that [1] but I should have been more clear ("Please drop the current series, I'll send a new version.").
> Or, of > course, send little fixes against the current version.
I prefer a full resend when there are bigger changes that involve modifications to multiple patches ... which also makes life easier for reviewers.
[1] https://lore.kernel.org/all/87104912-6615-4917-eae1-6ae0a80677e1@redhat.com/T/#u
-- Thanks,
David / dhildenb
| |