lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 377/530] hwrng: imx-rngc - Moving IRQ handler registering after imx_rngc_irq_mask_clear()
    Date
    From: Kshitiz Varshney <kshitiz.varshney@nxp.com>

    [ Upstream commit 10a2199caf437e893d9027d97700b3c6010048b7 ]

    Issue:
    While servicing interrupt, if the IRQ happens to be because of a SEED_DONE
    due to a previous boot stage, you end up completing the completion
    prematurely, hence causing kernel to crash while booting.

    Fix:
    Moving IRQ handler registering after imx_rngc_irq_mask_clear()

    Fixes: 1d5449445bd0 (hwrng: mx-rngc - add a driver for Freescale RNGC)
    Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/char/hw_random/imx-rngc.c | 14 +++++++-------
    1 file changed, 7 insertions(+), 7 deletions(-)

    --- a/drivers/char/hw_random/imx-rngc.c
    +++ b/drivers/char/hw_random/imx-rngc.c
    @@ -270,13 +270,6 @@ static int imx_rngc_probe(struct platfor
    goto err;
    }

    - ret = devm_request_irq(&pdev->dev,
    - irq, imx_rngc_irq, 0, pdev->name, (void *)rngc);
    - if (ret) {
    - dev_err(rngc->dev, "Can't get interrupt working.\n");
    - goto err;
    - }
    -
    init_completion(&rngc->rng_op_done);

    rngc->rng.name = pdev->name;
    @@ -290,6 +283,13 @@ static int imx_rngc_probe(struct platfor

    imx_rngc_irq_mask_clear(rngc);

    + ret = devm_request_irq(&pdev->dev,
    + irq, imx_rngc_irq, 0, pdev->name, (void *)rngc);
    + if (ret) {
    + dev_err(rngc->dev, "Can't get interrupt working.\n");
    + return ret;
    + }
    +
    if (self_test) {
    ret = imx_rngc_self_test(rngc);
    if (ret) {

    \
     
     \ /
      Last update: 2022-10-24 16:13    [W:6.491 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site