lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 075/530] ksmbd: fix endless loop when encryption for response fails
    Date
    From: Namjae Jeon <linkinjeon@kernel.org>

    commit 360c8ee6fefdb496fffd2c18bb9a96a376a1a804 upstream.

    If ->encrypt_resp return error, goto statement cause endless loop.
    It send an error response immediately after removing it.

    Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers")
    Cc: stable@vger.kernel.org
    Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ksmbd/server.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/fs/ksmbd/server.c
    +++ b/fs/ksmbd/server.c
    @@ -235,10 +235,8 @@ send:
    if (work->sess && work->sess->enc && work->encrypted &&
    conn->ops->encrypt_resp) {
    rc = conn->ops->encrypt_resp(work);
    - if (rc < 0) {
    + if (rc < 0)
    conn->ops->set_rsp_status(work, STATUS_DATA_ERROR);
    - goto send;
    - }
    }

    ksmbd_conn_write(work);

    \
     
     \ /
      Last update: 2022-10-24 16:08    [W:3.265 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site