lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 282/530] HSI: omap_ssi: Fix refcount leak in ssi_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 9a2ea132df860177b33c9fd421b26c4e9a0a9396 ]

    When returning or breaking early from a
    for_each_available_child_of_node() loop, we need to explicitly call
    of_node_put() on the child node to possibly release the node.

    Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hsi/controllers/omap_ssi_core.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
    index 44a3f5660c10..eb9820158318 100644
    --- a/drivers/hsi/controllers/omap_ssi_core.c
    +++ b/drivers/hsi/controllers/omap_ssi_core.c
    @@ -524,6 +524,7 @@ static int ssi_probe(struct platform_device *pd)
    if (!childpdev) {
    err = -ENODEV;
    dev_err(&pd->dev, "failed to create ssi controller port\n");
    + of_node_put(child);
    goto out3;
    }
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 16:03    [W:2.658 / U:0.904 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site