lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 100/530] ext4: fix miss release buffer head in ext4_fc_write_inode
    Date
    From: Ye Bin <yebin10@huawei.com>

    commit ccbf8eeb39f2ff00b54726a2b20b35d788c4ecb5 upstream.

    In 'ext4_fc_write_inode' function first call 'ext4_get_inode_loc' get 'iloc',
    after use it miss release 'iloc.bh'.
    So just release 'iloc.bh' before 'ext4_fc_write_inode' return.

    Cc: stable@kernel.org
    Signed-off-by: Ye Bin <yebin10@huawei.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Link: https://lore.kernel.org/r/20220914100859.1415196-1-yebin10@huawei.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ext4/fast_commit.c | 15 +++++++++------
    1 file changed, 9 insertions(+), 6 deletions(-)

    --- a/fs/ext4/fast_commit.c
    +++ b/fs/ext4/fast_commit.c
    @@ -794,22 +794,25 @@ static int ext4_fc_write_inode(struct in
    tl.fc_tag = cpu_to_le16(EXT4_FC_TAG_INODE);
    tl.fc_len = cpu_to_le16(inode_len + sizeof(fc_inode.fc_ino));

    + ret = -ECANCELED;
    dst = ext4_fc_reserve_space(inode->i_sb,
    sizeof(tl) + inode_len + sizeof(fc_inode.fc_ino), crc);
    if (!dst)
    - return -ECANCELED;
    + goto err;

    if (!ext4_fc_memcpy(inode->i_sb, dst, &tl, sizeof(tl), crc))
    - return -ECANCELED;
    + goto err;
    dst += sizeof(tl);
    if (!ext4_fc_memcpy(inode->i_sb, dst, &fc_inode, sizeof(fc_inode), crc))
    - return -ECANCELED;
    + goto err;
    dst += sizeof(fc_inode);
    if (!ext4_fc_memcpy(inode->i_sb, dst, (u8 *)ext4_raw_inode(&iloc),
    inode_len, crc))
    - return -ECANCELED;
    -
    - return 0;
    + goto err;
    + ret = 0;
    +err:
    + brelse(iloc.bh);
    + return ret;
    }

    /*

    \
     
     \ /
      Last update: 2022-10-24 15:47    [W:4.096 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site