lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 313/390] regulator: core: Prevent integer underflow
    Date
    From: Patrick Rudolph <patrick.rudolph@9elements.com>

    [ Upstream commit 8d8e16592022c9650df8aedfe6552ed478d7135b ]

    By using a ratio of delay to poll_enabled_time that is not integer
    time_remaining underflows and does not exit the loop as expected.
    As delay could be derived from DT and poll_enabled_time is defined
    in the driver this can easily happen.

    Use a signed iterator to make sure that the loop exits once
    the remaining time is negative.

    Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
    Link: https://lore.kernel.org/r/20220909125954.577669-1-patrick.rudolph@9elements.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
    index 317d701487ec..bf8ba73d6c7c 100644
    --- a/drivers/regulator/core.c
    +++ b/drivers/regulator/core.c
    @@ -2544,7 +2544,7 @@ static int _regulator_do_enable(struct regulator_dev *rdev)
    * expired, return -ETIMEDOUT.
    */
    if (rdev->desc->poll_enabled_time) {
    - unsigned int time_remaining = delay;
    + int time_remaining = delay;

    while (time_remaining > 0) {
    _regulator_enable_delay(rdev->desc->poll_enabled_time);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 15:28    [W:4.857 / U:0.672 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site