lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 213/390] fpga: prevent integer overflow in dfl_feature_ioctl_set_irq()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 939bc5453b8cbdde9f1e5110ce8309aedb1b501a ]

    The "hdr.count * sizeof(s32)" multiplication can overflow on 32 bit
    systems leading to memory corruption. Use array_size() to fix that.

    Fixes: 322b598be4d9 ("fpga: dfl: introduce interrupt trigger setting API")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Xu Yilun <yilun.xu@intel.com>
    Link: https://lore.kernel.org/r/YxBAtYCM38dM7yzI@kili
    Signed-off-by: Xu Yilun <yilun.xu@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/fpga/dfl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
    index b450870b75ed..eb8a6e329af9 100644
    --- a/drivers/fpga/dfl.c
    +++ b/drivers/fpga/dfl.c
    @@ -1857,7 +1857,7 @@ long dfl_feature_ioctl_set_irq(struct platform_device *pdev,
    return -EINVAL;

    fds = memdup_user((void __user *)(arg + sizeof(hdr)),
    - hdr.count * sizeof(s32));
    + array_size(hdr.count, sizeof(s32)));
    if (IS_ERR(fds))
    return PTR_ERR(fds);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 15:17    [W:4.020 / U:0.508 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site