lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 094/390] MIPS: SGI-IP27: Free some unused memory
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 33d7085682b4aa212ebfadbc21da81dfefaaac16 ]

    platform_device_add_data() duplicates the memory it is passed. So we can
    free some memory to save a few bytes that would remain unused otherwise.

    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Stable-dep-of: 11bec9cba4de ("MIPS: SGI-IP27: Fix platform-device leak in bridge_platform_create()")
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/mips/sgi-ip27/ip27-xtalk.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/arch/mips/sgi-ip27/ip27-xtalk.c b/arch/mips/sgi-ip27/ip27-xtalk.c
    index 000ede156bdc..e762886d1dda 100644
    --- a/arch/mips/sgi-ip27/ip27-xtalk.c
    +++ b/arch/mips/sgi-ip27/ip27-xtalk.c
    @@ -53,6 +53,8 @@ static void bridge_platform_create(nasid_t nasid, int widget, int masterwid)
    }
    platform_device_add_resources(pdev, &w1_res, 1);
    platform_device_add_data(pdev, wd, sizeof(*wd));
    + /* platform_device_add_data() duplicates the data */
    + kfree(wd);
    platform_device_add(pdev);

    bd = kzalloc(sizeof(*bd), GFP_KERNEL);
    @@ -83,6 +85,8 @@ static void bridge_platform_create(nasid_t nasid, int widget, int masterwid)
    bd->io_offset = offset;

    platform_device_add_data(pdev, bd, sizeof(*bd));
    + /* platform_device_add_data() duplicates the data */
    + kfree(bd);
    platform_device_add(pdev);
    pr_info("xtalk:n%d/%x bridge widget\n", nasid, widget);
    return;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 15:11    [W:4.042 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site