lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 137/390] bnx2x: fix potential memory leak in bnx2x_tpa_stop()
    Date
    From: Jianglei Nie <niejianglei2021@163.com>

    [ Upstream commit b43f9acbb8942b05252be83ac25a81cec70cc192 ]

    bnx2x_tpa_stop() allocates a memory chunk from new_data with
    bnx2x_frag_alloc(). The new_data should be freed when gets some error.
    But when "pad + len > fp->rx_buf_size" is true, bnx2x_tpa_stop() returns
    without releasing the new_data, which will lead to a memory leak.

    We should free the new_data with bnx2x_frag_free() when "pad + len >
    fp->rx_buf_size" is true.

    Fixes: 07b0f00964def8af9321cfd6c4a7e84f6362f728 ("bnx2x: fix possible panic under memory stress")
    Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
    index 198e041d8410..4f669e7c7558 100644
    --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
    +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
    @@ -788,6 +788,7 @@ static void bnx2x_tpa_stop(struct bnx2x *bp, struct bnx2x_fastpath *fp,
    BNX2X_ERR("skb_put is about to fail... pad %d len %d rx_buf_size %d\n",
    pad, len, fp->rx_buf_size);
    bnx2x_panic();
    + bnx2x_frag_free(fp, new_data);
    return;
    }
    #endif
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 15:11    [W:4.037 / U:0.748 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site