lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 064/390] ext4: dont increase iversion counter for ea_inodes
    Date
    From: Lukas Czerner <lczerner@redhat.com>

    commit 50f094a5580e6297bf10a807d16f0ee23fa576cf upstream.

    ea_inodes are using i_version for storing part of the reference count so
    we really need to leave it alone.

    The problem can be reproduced by xfstest ext4/026 when iversion is
    enabled. Fix it by not calling inode_inc_iversion() for EXT4_EA_INODE_FL
    inodes in ext4_mark_iloc_dirty().

    Cc: stable@kernel.org
    Signed-off-by: Lukas Czerner <lczerner@redhat.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Reviewed-by: Jeff Layton <jlayton@kernel.org>
    Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
    Link: https://lore.kernel.org/r/20220824160349.39664-1-lczerner@redhat.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ext4/inode.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    --- a/fs/ext4/inode.c
    +++ b/fs/ext4/inode.c
    @@ -5769,7 +5769,12 @@ int ext4_mark_iloc_dirty(handle_t *handl
    }
    ext4_fc_track_inode(handle, inode);

    - if (IS_I_VERSION(inode))
    + /*
    + * ea_inodes are using i_version for storing reference count, don't
    + * mess with it
    + */
    + if (IS_I_VERSION(inode) &&
    + !(EXT4_I(inode)->i_flags & EXT4_EA_INODE_FL))
    inode_inc_iversion(inode);

    /* the do_update_inode consumes one bh->b_count */

    \
     
     \ /
      Last update: 2022-10-24 15:05    [W:4.046 / U:0.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site