lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 253/255] efi: libstub: drop pointless get_memory_map() call
    Date
    From: Ard Biesheuvel <ardb@kernel.org>

    commit d80ca810f096ff66f451e7a3ed2f0cd9ef1ff519 upstream.

    Currently, the non-x86 stub code calls get_memory_map() redundantly,
    given that the data it returns is never used anywhere. So drop the call.

    Cc: <stable@vger.kernel.org> # v4.14+
    Fixes: 24d7c494ce46 ("efi/arm-stub: Round up FDT allocation to mapping size")
    Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/firmware/efi/libstub/fdt.c | 8 --------
    1 file changed, 8 deletions(-)

    --- a/drivers/firmware/efi/libstub/fdt.c
    +++ b/drivers/firmware/efi/libstub/fdt.c
    @@ -291,14 +291,6 @@ efi_status_t allocate_new_fdt_and_exit_b
    goto fail;
    }

    - /*
    - * Now that we have done our final memory allocation (and free)
    - * we can get the memory map key needed for exit_boot_services().
    - */
    - status = efi_get_memory_map(sys_table, &map);
    - if (status != EFI_SUCCESS)
    - goto fail_free_new_fdt;
    -
    status = update_fdt(sys_table, (void *)fdt_addr, fdt_size,
    (void *)*new_fdt_addr, MAX_FDT_SIZE, cmdline_ptr,
    initrd_addr, initrd_size);

    \
     
     \ /
      Last update: 2022-10-24 15:02    [W:6.292 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site