lkml.org 
[lkml]   [2022]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 171/255] powerpc/sysdev/fsl_msi: Add missing of_node_put()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit def435c04ee984a5f9ed2711b2bfe946936c6a21 ]

    In fsl_setup_msi_irqs(), use of_node_put() to drop the reference
    returned by of_parse_phandle().

    Fixes: 895d603f945ba ("powerpc/fsl_msi: add support for the fsl, msi property in PCI nodes")
    Co-authored-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20220704145233.278539-1-windhl@126.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/sysdev/fsl_msi.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c
    index 808e7118abfc..d276c5e96445 100644
    --- a/arch/powerpc/sysdev/fsl_msi.c
    +++ b/arch/powerpc/sysdev/fsl_msi.c
    @@ -211,8 +211,10 @@ static int fsl_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
    dev_err(&pdev->dev,
    "node %pOF has an invalid fsl,msi phandle %u\n",
    hose->dn, np->phandle);
    + of_node_put(np);
    return -EINVAL;
    }
    + of_node_put(np);
    }

    for_each_pci_msi_entry(entry, pdev) {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-24 14:54    [W:4.447 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site