lkml.org 
[lkml]   [2022]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 18/28] mfd: t7l66xb: Remove #ifdef guards for PM related functions
    Date
    Use the new pm_sleep_ptr() macro to handle the .suspend/.resume
    callbacks.

    This macro allow the suspend and resume functions to be automatically
    dropped by the compiler when CONFIG_SUSPEND is disabled, without having
    to use #ifdef guards.

    This has the advantage of always compiling these functions in,
    independently of any Kconfig option. Thanks to that, bugs and other
    regressions are subsequently easier to catch.

    Signed-off-by: Paul Cercueil <paul@crapouillou.net>
    ---
    drivers/mfd/t7l66xb.c | 9 ++-------
    1 file changed, 2 insertions(+), 7 deletions(-)

    diff --git a/drivers/mfd/t7l66xb.c b/drivers/mfd/t7l66xb.c
    index 663ffd4b8570..1d9d1d38d068 100644
    --- a/drivers/mfd/t7l66xb.c
    +++ b/drivers/mfd/t7l66xb.c
    @@ -257,7 +257,6 @@ static void t7l66xb_detach_irq(struct platform_device *dev)

    /*--------------------------------------------------------------------------*/

    -#ifdef CONFIG_PM
    static int t7l66xb_suspend(struct platform_device *dev, pm_message_t state)
    {
    struct t7l66xb *t7l66xb = platform_get_drvdata(dev);
    @@ -288,10 +287,6 @@ static int t7l66xb_resume(struct platform_device *dev)

    return 0;
    }
    -#else
    -#define t7l66xb_suspend NULL
    -#define t7l66xb_resume NULL
    -#endif

    /*--------------------------------------------------------------------------*/

    @@ -416,8 +411,8 @@ static struct platform_driver t7l66xb_platform_driver = {
    .driver = {
    .name = "t7l66xb",
    },
    - .suspend = t7l66xb_suspend,
    - .resume = t7l66xb_resume,
    + .suspend = pm_sleep_ptr(t7l66xb_suspend),
    + .resume = pm_sleep_ptr(t7l66xb_resume),
    .probe = t7l66xb_probe,
    .remove = t7l66xb_remove,
    };
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-10-23 11:53    [W:8.014 / U:0.716 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site