Messages in this thread | | | From | Angus Chen <> | Subject | RE: [PATCH v2] vDPA: rename get_vq_num_max to get_vq_size_max | Date | Mon, 24 Oct 2022 02:16:10 +0000 |
| |
Hi Jason
> -----Original Message----- > From: Jason Wang <jasowang@redhat.com> > Sent: Monday, October 24, 2022 10:01 AM > To: Angus Chen <angus.chen@jaguarmicro.com> > Cc: mst@redhat.com; virtualization@lists.linux-foundation.org; > linux-kernel@vger.kernel.org; lingshan.zhu@intel.com > Subject: Re: [PATCH v2] vDPA: rename get_vq_num_max to get_vq_size_max > > On Mon, Oct 24, 2022 at 9:56 AM Angus Chen <angus.chen@jaguarmicro.com> > wrote: > > > > The get_vq_num_max of vdpa_config_ops is mean get the max size of vq,not > > the max number of vq,it is kind of confused,rename it. > > And get_vq_num_min rename to get_vq_size_min, > > set_vq_num rename to set_vq_size, > > rename implement of this ops also. > > > > Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com> > > --- > > Not a native sparker. But num_max came from virtqueue structure: > > /* > ... > * @num_max: the maximum number of elements supported by the device. > ... > */ > > struct virtqueue { > ... > unsigned int num_max; I noticed this also,and I always confused by the definition. Take virtio_pci_common_cfg for example:
/* Fields in VIRTIO_PCI_CAP_COMMON_CFG: */ struct virtio_pci_common_cfg { ... __le16 num_queues; /* read-only */
It just a suggestion. Thank you. > ... > }; > > Thanks
| |