Messages in this thread | | | From | Kuninori Morimoto <> | Subject | Re: [PATCH v1 1/2] ASoC: simple-card: Support custom DAI system clock IDs | Date | Sun, 23 Oct 2022 23:54:14 +0000 |
| |
Hi Aidan
Thank you for your patch
> Some DAIs have multiple system clock sources, which can be chosen > using the "clk_id" argument to snd_soc_dai_set_sysclk(). Currently > this is hardcoded to 0 when using simple cards, but that choice is > not always suitable. > > Add the "system-clock-id" property to allow selecting a different > clock ID on a per-DAI basis. > > To simplify the logic on DPCM cards, add a dummy "asoc_simple_dai" > instance and use that for the dummy components on DPCM links. This > ensures that when we're iterating over DAIs in the PCM runtime there > is always a matching "asoc_simple_dai" we can dereference. > > Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com> > ---
I think adding "system-clock-id" and adding "dummy asoc_simple_dai" are different topics. This patch should be separated into 2 patches.
And I couldn't understand the reason why we need to add dummy asoc_simple_dai. In my understanding, we don't parse DT for dummy connection. Which process are you talking about specifically here?
This ensures that when we're iterating over DAIs in the PCM runtime there is always a matching "asoc_simple_dai" we can dereference. Thank you for your help !!
Best regards --- Kuninori Morimoto
| |