lkml.org 
[lkml]   [2022]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 134/717] ext4: fix potential memory leak in ext4_fc_record_modified_inode()
    Date
    From: Ye Bin <yebin10@huawei.com>

    commit 9305721a309fa1bd7c194e0d4a2335bf3b29dca4 upstream.

    As krealloc may return NULL, in this case 'state->fc_modified_inodes'
    may not be freed by krealloc, but 'state->fc_modified_inodes' already
    set NULL. Then will lead to 'state->fc_modified_inodes' memory leak.

    Cc: stable@kernel.org
    Signed-off-by: Ye Bin <yebin10@huawei.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Link: https://lore.kernel.org/r/20220921064040.3693255-2-yebin10@huawei.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ext4/fast_commit.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    --- a/fs/ext4/fast_commit.c
    +++ b/fs/ext4/fast_commit.c
    @@ -1494,13 +1494,15 @@ static int ext4_fc_record_modified_inode
    if (state->fc_modified_inodes[i] == ino)
    return 0;
    if (state->fc_modified_inodes_used == state->fc_modified_inodes_size) {
    - state->fc_modified_inodes = krealloc(
    - state->fc_modified_inodes,
    + int *fc_modified_inodes;
    +
    + fc_modified_inodes = krealloc(state->fc_modified_inodes,
    sizeof(int) * (state->fc_modified_inodes_size +
    EXT4_FC_REPLAY_REALLOC_INCREMENT),
    GFP_KERNEL);
    - if (!state->fc_modified_inodes)
    + if (!fc_modified_inodes)
    return -ENOMEM;
    + state->fc_modified_inodes = fc_modified_inodes;
    state->fc_modified_inodes_size +=
    EXT4_FC_REPLAY_REALLOC_INCREMENT;
    }

    \
     
     \ /
      Last update: 2022-10-22 09:46    [W:4.581 / U:0.548 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site