Messages in this thread | | | Date | Fri, 21 Oct 2022 11:21:06 +0530 | Subject | Re: [PATCH v4 11/11] staging: r8188eu: Remove unused macros | From | Praveen Kumar <> |
| |
On 21-10-2022 03:02, Deepak R Varma wrote: > Simple variants of macros PlatformEFIOWrite and PlatformEFIORead are > defined but never used. As they do not appear to be designed for anything > significant, we can remove them to avoid unexpected usage. > > Suggested-by: Julia Lawall <julia.lawall@inria.fr> > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- > > Changes in v4: > 1. Patch newly added to the patch set. > > > drivers/staging/r8188eu/include/rtw_io.h | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/staging/r8188eu/include/rtw_io.h b/drivers/staging/r8188eu/include/rtw_io.h > index 87fcf6c94ff3..e9744694204b 100644 > --- a/drivers/staging/r8188eu/include/rtw_io.h > +++ b/drivers/staging/r8188eu/include/rtw_io.h > @@ -285,18 +285,4 @@ void bus_sync_io(struct io_queue *pio_q); > u32 _ioreq2rwmem(struct io_queue *pio_q); > void dev_power_down(struct adapter *Adapter, u8 bpwrup); > > -#define PlatformEFIOWrite1Byte(_a, _b, _c) \ > - rtw_write8(_a, _b, _c) > -#define PlatformEFIOWrite2Byte(_a, _b, _c) \ > - rtw_write16(_a, _b, _c) > -#define PlatformEFIOWrite4Byte(_a, _b, _c) \ > - rtw_write32(_a, _b, _c) > - > -#define PlatformEFIORead1Byte(_a, _b) \
Can the naming be reworked to make more Linux friendly ? something like PLATFORM_EFIO_READ1BYTE or better if there are other suggestions? Rest others as applicable ?
> - rtw_read8(_a, _b) > -#define PlatformEFIORead2Byte(_a, _b) \ > - rtw_read16(_a, _b) > -#define PlatformEFIORead4Byte(_a, _b) \ > - rtw_read32(_a, _b) > - > #endif /* _RTL8711_IO_H_ */ > -- > 2.30.2 > > > Regards,
~Praveen.
| |