Messages in this thread | | | Date | Fri, 21 Oct 2022 08:59:46 -0400 | Subject | Re: [PATCH v3 1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states | From | Krzysztof Kozlowski <> |
| |
On 21/10/2022 08:54, Amjad Ouled-Ameur wrote: > Hi > > On 10/20/22 14:49, Krzysztof Kozlowski wrote: >>>>> + properties: >>>>> + pinctrl-names: >>>>> + minItems: 1 >>>>> + items: >>>>> + - const: default >>>>> + - const: idle-high >>>>> + - const: idle-low >>>> You should also define in such case pinctrl-0 and others. >>> Ok I thought it would be covered by the pinctrl-consumer.yaml >>> but yeah we should allow pinctrl-1 and pinctrl-2 here aswell by adding: >>> >>> pinctrl-1: true >>> pinctrl-2: true >>> >>> > In such case, should I define pinctrl- as part of the if statement, as shown below, > > or before allOf ?
The same as pinctrl-names, so part of allOf.
> > [...] > > - if: > properties: > compatible: > contains: > enum: > - amlogic,meson-gx-spicc > > then: > properties: > pinctrl-0: true > pinctrl-1: true > pinctrl-2: true > > pinctrl-names: > minItems: 1 > items: > - const: default > - const: idle-high > - const: idle-low
Best regards, Krzysztof
| |